[Bug 242940] games/devilutionX 1.0.0: version update and fixed some issues

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242940

malavon <benny.goemans at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #210375|0                           |1
        is obsolete|                            |
 Attachment #210391|                            |maintainer-approval+
              Flags|                            |

--- Comment #5 from malavon <benny.goemans at gmail.com> ---
Created attachment 210391
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=210391&action=edit
Patch to upgrade devilutionX to version 1.0.0 and fix issues post review

Hi Steve,

thanks for the review, I really appreciate it.
I've uploaded a modified patch and here are my 2 cents on your review points.

> LOCALBASE (...)
Replaced with PREFIX in the CMAKE_INSTALL_SHAREDIR variable

> CMAKE_BUILD_TYPE is already set based on WITH_DEBUG (...)
I'm not sure what you mean with this one. Do you mean the NIGHTLY/RELEASE
option?
These are an upstream thing. What I could do is set the NIGHTLY=ON option when
WITH_DEBUG is on. Any ideas if this would be a good idea?

> (...) __BSD_VISIBLE (...)
Yes, that was the hack I had before. I've had some comments on this before.
The patch removes these hacks from the port's patches.

> (...) remove the OS name from devilutionx.desktop (...)
Done. It is indeed better like this.

-- 
You are receiving this mail because:
You are the assignee for the bug.