[Bug 244314] devel/py-pygit2: fix RUN_DEPENDS definition

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244314

            Bug ID: 244314
           Summary: devel/py-pygit2: fix RUN_DEPENDS definition
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: mfechner at FreeBSD.org
          Reporter: jcfyecrayz at liamekaens.com
             Flags: maintainer-feedback?(mfechner at FreeBSD.org)
          Assignee: mfechner at FreeBSD.org

Created attachment 211837
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=211837&action=edit
[patch] don't define RUN_DEPENDS based on BUILD_DEPENDS

The porter's handbook advises that RUN_DEPENDS should be defined based on
BUILD_DEPENDS.

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#makefile-run_depends

portlint noticed the problem:

FATAL: Makefile: RUN_DEPENDS should not be set to ${BUILD_DEPENDS} as
${BUILD_DEPENDS} includes other implicit dependencies.  Instead, copy the
explicit dependencies from BUILD_DEPENDS to RUN_DEPENDS.  See
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#AEN2154
for more details.

It's probably okay to include this fix with a later change.  There is a chance
that some change to Uses/python.mk causes additional BUILD_DEPENDS that would
then propagate to RUN_DEPENDS, thus changing the package.  But the likelihood
of such a change seems low.  So this change can wait to be included with
another future change (e.g., PORTVERSION update).

-- 
You are receiving this mail because:
You are the assignee for the bug.