[Bug 244120] [PATCH] Mk/bsd.port.mk: Clarify description of OSREL/OSVERSION

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244120

Adam Weinberger <adamw at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adamw at FreeBSD.org

--- Comment #1 from Adam Weinberger <adamw at FreeBSD.org> ---
This doesn't seem any clearer to me, because reading those strings, I can't
predict what would be in each one. It almost implies that OSREL might not have
numbers.

I've two suggestions for you to consider:
1) Call it "integer" instead of "numeric." "12.1" is still numeric.
2) Examples could make it clearer

OSREL - The release version of the operating system (12.1).

OSVERSION - The operating system version as an integer; the value of
__FreeBSD_version (120100).

-- 
You are receiving this mail because:
You are on the CC list for the bug.