[Bug 243971] [NEW PORT] www/py-gdown: Download files from google drive

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243971

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |maintainer-feedback?(FreeBS
                   |                            |D at ShaneWare.Biz)
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
                 CC|                            |FreeBSD at ShaneWare.Biz
            Summary|New port www/py-gdown:      |[NEW PORT] www/py-gdown:
                   |python module and cli cmd   |Download files from google
                   |to download files from      |drive
                   |google drive                |
             Status|New                         |Open

--- Comment #1 from Kubilay Kocak <koobs at FreeBSD.org> ---
gdown depends on "requests[socks]" , the "requests" packages
extras_require=socks[...] dependency list [1].

When declaring dependencies for packages that declare dependencies on
package[extras] form, the port must depend on those dependencies directly [2]

requests[socks] is currently defined in requests setup.py [3] as:

  extras_require { 'socks': ['PySocks>=1.5.6, !=1.5.7'], }

If, in fact, "socks" functionality in gdown is *not* compulsory, but instead
OPTIONAL, then gdown should list and declare the socks dependency in
extras_require (optional dependencies), not install_requires (compulsory
dependencies)

gdown, could for example do:

  install_requires = requests (compulsory base requests functionality)
  extras_require = requests[socks], or directly on pysocks (optional socks
support)


[1] gdown:setup.py: install_requires=['filelock', 'requests[socks]', 'six',
'tqdm'],
[2] https://wiki.freebsd.org/Python/PortsPolicy#Transitive_Dependencies
[3] requests:setup.py:extras_requite = { ... , 'socks': ['PySocks>=1.5.6,
!=1.5.7'], ... }

-- 
You are receiving this mail because:
You are the assignee for the bug.