[Bug 243864] emulators/open-vm-tools-nox11: fails to build after r357287 and/or r357403

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243864

            Bug ID: 243864
           Summary: emulators/open-vm-tools-nox11: fails to build after
                    r357287 and/or r357403
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: jpaetzel at FreeBSD.org
          Reporter: brigadir15 at gmail.com
          Assignee: jpaetzel at FreeBSD.org
             Flags: maintainer-feedback?(jpaetzel at FreeBSD.org)

Created attachment 211338
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=211338&action=edit
Remove the VDESC_NOMAP_VPP and VDESC_VPP_WILLRELE flags

I'm trying to build emulators/open-vm-tools-nox11 on FreeBSD 13.0-CURRENT
r357195 with /usr/src updated to r357494:

# cd /usr/ports/emulators/open-vm-tools-nox11
# make build
...
vnops.c:536:31: error: use of undeclared identifier 'VDESC_NOMAP_VPP'
       !(descp->vdesc_flags & VDESC_NOMAP_VPP) &&
                              ^

vnops.c:543:32: error: use of undeclared identifier 'VDESC_VPP_WILLRELE'
      if (descp->vdesc_flags & VDESC_VPP_WILLRELE) {
                               ^

2 errors generated
...

The first error is caused by r357287[1] which removed the VDESC_NOMAP_VPP flag.
 The second one -- by r357403[2] which removed the VDESC_VPP_WILLRELE flag.

I picked the changes made in those revisions in file sys/fs/nullfs/null_vnops.c
and applied them to the port's file modules/freebsd/vmblock/vnops.c using
define-guards.  But, because neither r357287, nor r357403 changed the
__FreeBSD_version, I have to use `#if __FreeBSD_version < 1300076` to be able
to build the port on FreeBSD 13.0-CURRENT r357195 (which is 1300076; since
r356511[3]).  Therefore, the patch I attached may not be completely correct if
the removed flags somehow are in use between r356511 and r357287.

Please review.

[1] https://svnweb.freebsd.org/base?view=revision&revision=357287
[2] https://svnweb.freebsd.org/base?view=revision&revision=357403
[3] https://svnweb.freebsd.org/base?view=revision&revision=356511

-- 
You are receiving this mail because:
You are the assignee for the bug.