[Bug 251987] multimedia/get_iplayer: rc.d script emits error message even when disabled

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251987

--- Comment #5 from Jamie Landeg-Jones <jamie at catflap.org> ---
(In reply to Niels Bakker from comment #4)

Ahh, ok. Yes, the whole thing is passed through "eval", and would otherwise
fail without quotes if the home directory contained the space character, which
is perfectly valid. So the patch works.

However, on further inspection, rc.subr itself isn't compatible with space in
directories (xxx_chdir fails), so I guess this is moot.

Of course, the single quoting will still cause the script to fail if the path
contains a "'", but this is opening up another can of worms.... The whole
rc.subr system needs to be changed to cope with shell-special characters
really.

However, I have updated the patch to use the proper way of exporting variables
to daemons, and also fixed a typo in the original pkg-message.

Is this ok?

Cheers, Jamie

-- 
You are receiving this mail because:
You are the assignee for the bug.