[Bug 251822] net/miniupnpd: firewall type detection broken; upstream pull needed

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251822

            Bug ID: 251822
           Summary: net/miniupnpd: firewall type detection broken;
                    upstream pull needed
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: jeremy.fbbg at baymoo.org
                CC: squat at squat.no
                CC: squat at squat.no
             Flags: maintainer-feedback?(squat at squat.no)

SUMMARY

The current in-tree version of miniupnpd does not correctly detect the host
firewall type and defaults to building a version which is only compatible with
pf no matter the actual host firewall type.


DETAILS

miniupnpd supposedly can be built to use any one of the three supported FreeBSD
firewalls: pf, ipfilter and ipfw. The build process attempts to discern which
firewall to use by consulting /etc/rc.conf, but it does a poor job of doing so
because of a series of precondition checks it performs before attempting to
load /etc/rc.conf. These preconditions fail and /etc/rc.conf is never loaded.
The build process then falls back to building the pf version.


FIX

In March 2020 I notified the miniupnpd team about this issue, opening a pull
request and proposing a fix. The minupnp team accepted the change and
incorporated it into their master branch rather quickly and released with
miniupnp 2.2.0.

According to the the HEAD of ports SVN the port distinfo file is still pinned
at version 2.1.20190210. It was last edited as of ports r496821, which means
that it doesn't have the fix for this detection issue.


UPSTREAM ISSUE

The upstream pull request which fixes the firewall detection problem can be
found at

https://github.com/miniupnp/miniupnp/issues/431


UPSTREAM VERSION CONTAINING DETECTION FIX

The full fix for this issue was applied in

https://github.com/miniupnp/miniupnp/commit/040fbc40f86a88c14dd4d3f8409e878994839e76

Which then appears to have been incorporated into miniupnp version 2.2.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.