[Bug 248692] multimedia/kodi: Update to 18.8 and take maintainership

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248692

--- Comment #10 from James French <james at french.id.au> ---
(In reply to yzrh from comment #9)

No dramas on maintainer, I'll remove that line from my patch shortly, feel free
to submit one to do take it.

On the API, I'm not quite sure I've been understood. If you have a look at
multimedia/kodi-addon-pvr-hts/pkg-plist you'll see the following

lib/kodi/addons/pvr.hts/pvr.hts.so
lib/kodi/addons/pvr.hts/pvr.hts.so.18.7
lib/kodi/addons/pvr.hts/pvr.hts.so.4.4.21
share/kodi/addons/pvr.hts/addon.xml
share/kodi/addons/pvr.hts/changelog.txt
...

When that port gets built, the upstream build scripts identify which version of
Kodi is installed, and then generate that file. If we bump Kodi to 18.8 the
four ports I listed above error at packaging because their build now generates
*.so.18.8 (or in the case of kodi-platform case *.so.18.8.0). 

There's two ways to fix that, either we bump five ports between three
maintainers every time we bump this one (and hope we forget none of them) or we
can expose the API version to those ports and then bump just this port each
time. Doing it the second way, the patch for one of them is just:

diff -urN multimedia/kodi-addon-pvr-hts/Makefile
multimedia/kodi-addon-pvr-hts/Makefile
--- multimedia/kodi-addon-pvr-hts/Makefile      2020-07-19 13:40:42.366086000
+0800
+++ multimedia/kodi-addon-pvr-hts/Makefile      2020-08-17 17:19:48.848419000
+0800
@@ -22,4 +22,7 @@
 GH_PROJECT=    pvr.hts
 GH_TAGNAME=    ${PORTVERSION}-Leia

+.include "${CURDIR}../../multimedia/kodi/Makefile.addons"
+PLIST_SUB=     APIVERSION=${APIVERSION}
+
 .include <bsd.port.mk>
diff -urN multimedia/kodi-addon-pvr-hts/pkg-plist
multimedia/kodi-addon-pvr-hts/pkg-plist
--- multimedia/kodi-addon-pvr-hts/pkg-plist     2020-07-19 13:40:42.366547000
+0800
+++ multimedia/kodi-addon-pvr-hts/pkg-plist     2020-08-17 17:12:42.853153000
+0800
@@ -1,5 +1,5 @@
 lib/kodi/addons/pvr.hts/pvr.hts.so
-lib/kodi/addons/pvr.hts/pvr.hts.so.18.7
+lib/kodi/addons/pvr.hts/pvr.hts.so.%%APIVERSION%%
 lib/kodi/addons/pvr.hts/pvr.hts.so.4.4.21
 share/kodi/addons/pvr.hts/addon.xml
 share/kodi/addons/pvr.hts/changelog.txt

-- 
You are receiving this mail because:
You are the assignee for the bug.