[Bug 246042] [NEW PORT] net/wsdd: Web Service Discovery host daemon

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246042

daniel.engberg.lists at pyret.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.engberg.lists at pyret.
                   |                            |net

--- Comment #1 from daniel.engberg.lists at pyret.net ---
Nice work!

Perhaps be a bit more verbose about the description?
COMMENT=        Web Service Discovery (WSD) host daemon for Samba

Shouldn't USES be python:3.5+,run as it's only a run dependency?
https://svnweb.freebsd.org/ports/head/Mk/Uses/python.mk?revision=532396&view=markup#l39

Shouldn't NO_ARCH be set?
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-arch.html

Doesn't matter much but I think you can omit DOC_FILES as they doesn't provide
any useful documentation.

Manpage is missing, that should be installed.

post-patch --> Shebangfix doesn't work?
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/uses-shebangfix.html

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.