[Bug 239774] [NEW PORT] audio/playumidi Standard MIDI format 0/1 player for FreeBSD USB-MIDI(umidi) device

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Apr 26 19:12:32 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239774

--- Comment #4 from daniel.engberg.lists at pyret.net ---
Hi,

Much better now, I did however notice that the archive includes a license file
which you should have in your Makefile

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/licenses.html
LICENSE_FILE=   ${WRKSRC}/LICENSE

While at it, minor style fix but you can also drop the # libiconv and debug
lines. Your Makefile is so small so you can easily get a good overview of it
even without those comments.

Apart from those changes it looks ready to be committed as far as I can tell.

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list