[Bug 240526] x11/xlockmore: fix XLOCKLIBS if both MESAGL & KERBEROS5 options set (also KERBEROS5 is broken)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240526

            Bug ID: 240526
           Summary: x11/xlockmore: fix XLOCKLIBS if both MESAGL &
                    KERBEROS5 options set (also KERBEROS5 is broken)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: jgh at FreeBSD.org
          Reporter: jcfyecrayz at liamekaens.com
          Assignee: jgh at FreeBSD.org
             Flags: maintainer-feedback?(jgh at FreeBSD.org)

Created attachment 207409
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207409&action=edit
[patch] allow multiple values for XLOCKLIBS, fix KERBEROS5

If both MESAGL & KERBEROS5 options set, XLOCKLIBS is defined separately twice
in CONFIGURE_ENV (the last one winning).

Also, KERBEROS5 was broken.  If you build with KERBEROS5 option and either
KRB5_HOME=/usr/local and security/krb5 installed OR with KRB5_HOME=/usr, you
get a link error:

../xlock/passwd.o: In function `checkPasswd':
passwd.c:(.text+0x8f): undefined reference to `krb5_get_init_creds_opt_init'
passwd.c:(.text+0x9b): undefined reference to `krb5_init_context'
passwd.c:(.text+0xb5): undefined reference to `com_err'
passwd.c:(.text+0xdb): undefined reference to `krb5_parse_name'
passwd.c:(.text+0x100): undefined reference to `krb5_cc_default'
passwd.c:(.text+0x11a): undefined reference to `com_err'
 .
 .

Finally, USE_GL by itself is deprecated:

============
Using USE_GL alone is deprecated, please add USES=gl.

USE_GL=yes is deprecated, please add USE_GL=glu (default) or specify component
============

The attached patch addresses these issues:
 - Fix USES/USE_GL for gl components (MESAGL)
 - Fix kerberos libs (link error) & add USES=gssapi:mit (KERBEROS5) [1]
 - Fix XLOCKLIBS when both MESAGL & KERBEROS5 are selected

[1] Instead of USES=gssapi:mit in the patch, we could provide an option for
selecting which kerberos implementation to use.  Other ports provide a radio
choice for the other kerberos options (mit, heimdal, base) - e.g., see
net/wireshark and net/samba410.  Allowing a kerberos option choice could be
added later.

QA:
  poudriere testport with MESAGL & KERBEROS5 set: ok
  portlint: patch fixes a previous portlint warning [2]

[2]
WARN: Makefile: "BROKEN" has to appear earlier.

-- 
You are receiving this mail because:
You are the assignee for the bug.