[Bug 240382] [patch] net/radsecproxy update to v1.8.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240382

            Bug ID: 240382
           Summary: [patch] net/radsecproxy update to v1.8.0
           Product: Ports & Packages
           Version: Latest
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: freebsd at jornane.no
                CC: m.tsatsenko at gmail.com
                CC: m.tsatsenko at gmail.com
             Flags: maintainer-feedback?(m.tsatsenko at gmail.com)

Created attachment 207253
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207253&action=edit
net/radsecproxy patch 2019090600

It seems the net/radsecproxy port has not received any updates for some time.

- The port does currently not compile on FreeBSD 12 or FreeBSD 13.  

- The port still refers to version 1.6.8, which is two years old.  Version
1.8.0 came out two months ago.

- The project moved to Github and the old download location is not available
anymore.

I've updated the Makefile to refer to the new download location, and to the
newest version.  Version 1.8.0 seems to have a missing include statement but
compiles when that's fixed.  I've included a patch in the port for this, and
submitted the patch upstream [1].  I've also included a patch that corrects
paths in the example config file.

The port seems to run fine, I was able to connect to WiFi in a test setup where
radsecproxy 1.8.0 on 12.0-RELEASE received TLS traffic which it forwarded to a
local RADIUS server.  I didn't test this port on CURRENT though.

This is my first port work, there are two details I'm not sure about:

1. The radsecproxy example configuraion file states that the file should be
placed at /usr/local/etc/radsecproxy/radsecproxy.conf, but the FreeBSD port
uses /usr/local/etc/radsecproxy.conf. Should I correct this, provided that this
will break setups for those who already installed this port earlier?

2. The project uses autotools, but provides a manually built .tar.gz that comes
with a prebuilt configure script and Makefile. This file is not chosen by the
standard Github macros in the FreeBSD porting scripts. Is it preferable to use
autoreconf or to override the download location?

Please let me know if I can do anything to make this patch better.

[1] https://github.com/radsecproxy/radsecproxy/pull/53

-- 
You are receiving this mail because:
You are the assignee for the bug.