[Bug 240138] [NEW PORT] sysutils/libudisks: Library from udisks project, to access and manipulate disks, storage devices and technologies

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240138

--- Comment #18 from Ting-Wei Lan <lantw44 at gmail.com> ---
Comment on attachment 208102
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=208102
Patch for new port sysutils/libudisks

>+# pkaction takes care of libpolkit-agent-1 and libpolkit-gobject-1
>+# which are what we really want (see UDISKSCTL_LIB_DEPENDS).
>+BUILD_DEPENDS=	bash:shells/bash gtkdocize:textproc/gtk-doc \

Is there any reason to put two dependencies in one line here?

>+OPTIONS_DEFINE=	UDISKSCTL
>+OPTIONS_SUB=	yes
>+UDISKSCTL_DESC=	Install udisksctl command line utility
>+UDISKSCTL_LIB_DEPENDS=	libpolkit-agent-1.so:sysutils/polkit \
>+			libpolkit-gobject-1.so:sysutils/polkit

Can we enable UDISKSCTL by default? It is just a small tool that is useful for
testing. It also makes the port similar to the upstream default because the
upstream project doesn't have an option to disable udisksctl.

>+
>+# config.status errors out without --disable-dependency-tracking, with or
>+# without USES=gmake.
>+do-configure:
>+	cd ${WRKSRC} && \
>+	./autogen.sh --disable-daemon --disable-gtk-doc --disable-nls \

Why --disable-nls is used? If you think NLS should be optional, put it under
NLS option. NLS is enabled by default. --disable-gtk-doc should also be
optional, so users can decide if the documentation is needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.