[Bug 241095] net-p2p/transmission-cli: Drop defunct WOLFSSL option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241095

            Bug ID: 241095
           Summary: net-p2p/transmission-cli: Drop defunct WOLFSSL option
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: needs-qa
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: rigoletto at freebsd.org
          Reporter: tobik at freebsd.org
                CC: rigoletto at freebsd.org
             Flags: maintainer-feedback?(rigoletto at freebsd.org)
          Assignee: rigoletto at freebsd.org
 Attachment #208132 maintainer-approval?(rigoletto at freebsd.org)
             Flags:
                CC: rigoletto at freebsd.org

Created attachment 208132
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=208132&action=edit
transmission-cli.diff

There is no opt_CMAKE_ARGS helper, so WOLFSSL_CMAKE_ARGS and
OPENSSL_CMAKE_ARGS do nothing.  In CMakeLists.txt WITH_CRYPTO
defaults to "openssl".  With WOLFSSL=on the port is still linked
to OpenSSL since -DWITH_CRYPTO=cyassl is never passed to the build.
This is obviously not what is wanted.

Problem is that even when that is fixed building with WOLFSSL support
is broken due to missing enabled RC4 support in security/wolfssl
(cf, bug #207664).  This has not been addressed in over 3 years
now.  I think it might be time to just remove the complication from
transmission-cli altogether and not pretend there is functional
WolfSSL support.

Attached patch removes the OPENSSL and WOLFSSL options and makes
use of OpenSSL mandatory.  It also drops LITE_CONFIGURE_ENABLE which
does not make sense in a USES=cmake based port.

I have only tested building transmission-cli and not the slave
ports so this will need more QA.

-- 
You are receiving this mail because:
You are the assignee for the bug.