[Bug 237315] New port: net/pichi An Application Layer Proxy controlled via RESTful APIs

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237315

--- Comment #1 from Tobias Kortkamp <tobik at freebsd.org> ---
Comment on attachment 203718
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=203718
pichi.shar

Please add

# $FreeBSD$

to the first line then run portlint and fix everything it raises:

WARN: Makefile: [14]: USE_* seen before USES.  According to the
porters-handbook, USES must appear first.
WARN: pkg-descr: includes lines that exceed 80 characters.
WARN: Makefile: [39]: use tab (not space) to make indentation
WARN: Makefile: [40]: use tab (not space) to make indentation
WARN: Makefile: [41]: use tab (not space) to make indentation
WARN: Makefile: [43]: use tab (not space) to make indentation
WARN: Makefile: [44]: use tab (not space) to make indentation
WARN: Makefile: [45]: use tab (not space) to make indentation
WARN: Makefile: [46]: use tab (not space) to make indentation
WARN: Makefile: [47]: use tab (not space) to make indentation
WARN: Makefile: [48]: use tab (not space) to make indentation
WARN: Makefile: [49]: use tab (not space) to make indentation
WARN: Makefile: [50]: use tab (not space) to make indentation
WARN: Makefile: COMMENT is not supposed to begin with 'A ', 'An ', or 'The '.
WARN: Makefile: Setting PORTREVISION to 0 is not necessary.
WARN: Makefile: extra item placed in the USES/USE_x section, for example,
"PLIST_SUB".
WARN: Makefile: "BUILD_DEPENDS" has to appear earlier.
WARN: Makefile: "USES" has to appear earlier.
0 fatal errors and 18 warnings found.

Several of these items are formatting related, so please also try and
reformat the port like other ports are formatted. ports-mgmt/portfmt
can help you there.

XPLIST_SUB= VERSION=1.2.0

PLIST_SUB=      VERSION=${DISTVERSION}

XCMAKE_ARGS= -DCMAKE_CXX_FLAGS=NDEBUG -DVERSION=1.2.0

This looks bogus.  What is this supposed to do?

XINSTALL_TARGET= test install/strip

Hmm, this looks weird.  Note that we generally do not force our
users to run tests during regular builds.  Maybe add

TEST_TARGET=    test

instead?

X.if ${PORT_OPTIONS:MTLS}
XUSES+=  ssl
XSTATIC_BUILD_DEPENDS+= openssl:security/openssl
XSTATIC_LIB_DEPENDS_OFF+=       libssl.so:security/openssl
libcrypto.so:security/openssl
X.endif

This is wrong.  You can never depend on security/openssl directly
(users can select other versions of it and they are all mutually
exclusive to each other).  This should be something more like

.if ${PORT_OPTIONS:MTLS}
.if ${PORT_OPTIONS:MSTATIC}
USES+=  ssl:build
.else
USES+=  ssl
.endif
.endif

XTLS_DESC= Enable TLS support(requiring OpenSSL)

Add a space before '(' and s/requiring/requires/.

X       ${INSTALL_DATA} ${WRKSRC}/include/pichi.h
${STAGEDIR}${PREFIX}/include/pichi.h

Hmm, would this still be necessary if the INSTALL_HEADERS cmake
option would be enabled instead of disabled?

-- 
You are receiving this mail because:
You are the assignee for the bug.