[Bug 236891] lang/lua53: move assertion to correct place

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Mar 30 08:45:01 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236891

            Bug ID: 236891
           Summary: lang/lua53: move assertion to correct place
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: andrew at tao11.riddles.org.uk
                CC: russ.haley at gmail.com
             Flags: maintainer-feedback?(russ.haley at gmail.com)
                CC: russ.haley at gmail.com

Created attachment 203251
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=203251&action=edit
patch extra-patch-assert to move an incorrectly placed assertion

Per discussion on lua-l, the first assert in atomic() is misplaced and can
cause false failures; this patch moves it (only when asserts are enabled) to
the correct place.

This fix only affects assertion-enabled builds (which is not the default) and
only in relatively rare cases, so I think that PORTREVISION should probably not
be updated. I submit it anyway because as far as I know there are no plans for
an upstream fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list