[Bug 233010] x11/kitty: Cross-platform, fast, feature full, GPU based terminal emulator

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Mar 8 01:04:47 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233010

--- Comment #18 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 202705
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202705
More minor fixes

> USES=	gl gmake pkgconfig:build python:3.5+ shebangfix terminfo

pkgconfig defaults to build-only dependency, so you can drop :build argument.

> BINARY_ALIAS=	python3=${PYTHON_CMD}
[...]
> post-patch-DOCS-on:
> 	${REINPLACE_CMD} -e 's|python3|${PYTHON_CMD}|g' ${WRKSRC}/docs/Makefile
> 	${REINPLACE_CMD} -e 's|sphinx-build|&-${PYTHON_VER}|' ${WRKSRC}/docs/Makefile

Why both approaches? And do you still need either given DOCS is commented out?

> do-build:
> 	cd ${WRKSRC} && CC=clang ${PYTHON_CMD} setup.py --prefix ${STAGEDIR}${PREFIX} linux-package

- Replace CC=clang with ${SETENV} ${MAKE_ENV} to avoid breaking GCC
architectures (powerpc*, sparc64, mips*, riscv64*)
- Add USES=compiler:c11 (for -std=c11) to avoid ancient GCC 4.2 in base 

x11/kitty/files/patch-glfw_wl__init.c:
> --- glfw/wl_init.c.orig	2019-02-17 23:49:36 UTC
> +++ glfw/wl_init.c
> @@ -31,7 +31,7 @@
>  #include <assert.h>
>  #include <errno.h>
>  #include <limits.h>
> -#include <linux/input.h>
> +#include <dev/evdev/input.h>
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>

Drop in favor of BUILD_DEPENDS=evdev-proto>0:devel/evdev-proto. According to
wulf@ (maintainer of <dev/evdev/*>):
"The rule is simple: always use <linux/*> except you are writing something
FreeBSD-only like kernel drivers"

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list