[Bug 239334] mail/milter-greylist bring GeoIP support back, utilizing libmaxminddb implemented by Markus Wennrich

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Jul 22 14:59:33 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239334

--- Comment #2 from Harald Schmalzbauer <bugzilla.freebsd at omnilan.de> ---
Hello,

haven't included that change since up to now, there was a configure-patch in
place, instead of autoreconf.
I'll add a diff for switching to autoreconf additionally, which reduces
files/patch-libmaxminddb-support_from_GH-geoip2-fork significantly and removes
files/patch-configure.

I have no idea about yacc and bison, hence no idea about the corresponding
hunks in the diff, please check if it's correct what Markus Wennrich provides.

I also don't know if
MAXMINDDB_DESC=         Enable GeoIP1 + GeoIP2 Support
is correct.
I copied from a different port.  I assumed the author is right, but according
to https://maxmind.github.io/libmaxminddb/ he isn't, if I interpret the
description of "typedef struct MMDB_metadata_s" correctly, where we can read
»The binary_format_major_version should always be 2«.  Please correct this
before commiting.  I just randomly chose one port listed in
https://svnweb.freebsd.org/ports?view=revision&revision=490211, which also
needs finxing in case really is incorrect.

Again, if this patch isn't an immediate solution for you, please revert
r490200.
The GeoIP option removal badly breaks existing setups, which must not happen
for this kind of reason/event/problem (the discontinuance of upstream updates).

Thanks,
-harry

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list