[Bug 234888] ports-mgmt/portlint: overeager "WARN: Makefile: X appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE"

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234888

            Bug ID: 234888
           Summary: ports-mgmt/portlint: overeager "WARN: Makefile: X
                    appears in PORT_OPTIONS:M, but is not listed in
                    OPTIONS_DEFINE"
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: marcus at FreeBSD.org
          Reporter: gerald at FreeBSD.org
                CC: andreast at FreeBSD.org
             Flags: maintainer-feedback?(marcus at FreeBSD.org)
          Assignee: marcus at FreeBSD.org

Recently portlint started to issue the following warnings in most of my
lang/gcc* ports such as lang/gcc7:

  WARN: Makefile: MULTILIB appears in PORT_OPTIONS:M, but is not listed in   
  OPTIONS_DEFINE


If we look at lang/gcc7/Makefile we find

  OPTIONS_DEFINE=         BOOTSTRAP GRAPHITE
  :
  .if exists(/usr/lib32/libc.so)
  OPTIONS_DEFINE_powerpc64+=      MULTILIB
  :

so the later

  .if ${ARCH} == powerpc64 && ${PORT_OPTIONS:MMULTILIB}
        ${MKDIR} ${STAGEDIR}${TARGLIB32}/gcc${SUFFIX}
        ${MV}
${STAGEDIR}${PREFIX}/lib/lib32/*${STAGEDIR}${TARGLIB32}/gcc${SUFFIX}
  .endif

should be fine.  

(Well, technically the two .if-s do not feature exactly the same
condition, but I bet portlint would warn in any case.)


Suggested approach: combine the contents of *all* OPTIONS_DEFINE*
statements and use that superset for this warning.

-- 
You are receiving this mail because:
You are the assignee for the bug.