[Bug 234833] USES=autoreconf fails if a port uses gettext but user disables NLS port option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234833

--- Comment #3 from Matthias Andree <mandree at FreeBSD.org> ---
(In reply to Tijl Coosemans from comment #1)

Tijl, Antoine, thanks for your proposal, but it doesn't hold water. 

What you propose creates a build-time depends on gettext, which is unnecessary;
OTOH USES=autoreconf will go looking for autopoint without depending on it.

My point is that either the framework will need to make sure that either:
- it establishes that the unpacked distfile requires gettext, and creates
proper _DEPENDS entries,
- or that it establishes that gettext is not required, and then
Mk/Uses/autoreconf.mk needs to set AUTOPOINT=${TRUE} in autoreconf's
environment.

We should check if the other tools that autoreconf might depend on are treated
in the same vain.

With "the port uses gettext", I mean AM*GETTEXT() lines in configure.ac, not a
formal USES=gettext-whatever declaration.

My current workaround that avoids pulling gettext in at run-time, and that
works for mail/fetchmail, is:

USES=           autoreconf:build [...]    # <- part of workaround

OPTIONS_DEFINE= X11 NLS NTLM POP2 DOCS    # <- note NLS listed
NLS_USES=       gettext
NLS_CONFIGURE_ENABLE=   nls

# This is a workaround for a ports framework bug:
# As of r489889 on 2019-01-10, 
# USES=autoreconf does not seem to get along with disabling the NLS option,
# because this would not install gettext-tools, omitting autopoint,
# however the configure.ac requests GETTEXT, so autoreconf will barf.
# Pulling in gettext-tools unconditionally (even with NLS off) would 
# be excess and confuse users, so is not an option.
# Thus we set USES=autoreconf:build and run autoreconf by ourselves,
# overriding AUTOPOINT=true.
#
pre-configure-NLS-on:
        (cd ${WRKSRC} && ${LOCALBASE}/bin/autoreconf -f -i)
#
pre-configure-NLS-off:
        (cd ${WRKSRC} && ${SETENV} AUTOPOINT=${TRUE}
${LOCALBASE}/bin/autoreconf -f -i)

-- 
You are receiving this mail because:
You are on the CC list for the bug.