[Bug 234791] sysutils/node_exporter: Add license file, tests, docs and examples

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Jan 9 15:50:28 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234791

            Bug ID: 234791
           Summary: sysutils/node_exporter: Add license file, tests, docs
                    and examples
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
               URL: https://reviews.freebsd.org/D18792
                OS: Any
            Status: New
          Keywords: needs-qa, patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: 0mp at FreeBSD.org
                CC: ports at ecadlabs.com
                CC: ports at ecadlabs.com
             Flags: maintainer-feedback?(ports at ecadlabs.com)

Created attachment 200957
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=200957&action=edit
Patch

- Define LICENSE_FILE
- Sort variables
- Add a do-test target and prepare a testing environment.  One test is skipped
  at the moment due to a problem with detecting procfs(5) on FreeBSD.
- Install documentation and examples.
- Change pkg-descr to better match upstream's README.

I am not sure about a couple of things, however:

    Is it fine to use USES=gmake instead of TEST_DEPENDS=gmake:devel/gmake?
USES=gmake adds a dependency to the build process, which is not ideal.
    The whole pre-test target is rather hacky. I was unable to come up with a
prettier solution though. Go is a little bit hard to tame.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list