[Bug 234700] cad/opencascade: Do not set VIS_CMAKE_ON twice

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234700

            Bug ID: 234700
           Summary: cad/opencascade: Do not set VIS_CMAKE_ON twice
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: thierry at FreeBSD.org
          Reporter: tobik at freebsd.org
                CC: thierry at FreeBSD.org
          Assignee: thierry at FreeBSD.org
             Flags: maintainer-feedback?(thierry at FreeBSD.org)
 Attachment #200879 maintainer-approval?(thierry at FreeBSD.org)
             Flags:
                CC: thierry at FreeBSD.org

Created attachment 200879
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=200879&action=edit
cad__opencascade.diff

The port specifies VIS_CMAKE_ON twice like this

VIS_CMAKE_ON=           -DUSE_FREEIMAGE:BOOL=ON -DUSE_GL2PS:BOOL=ON     \
                        -DUSE_FREETYPE:BOOL=ON
[...]
VIS_CMAKE_ON=   -D3RDPARTY_FREETYPE_DIR=${LOCALBASE}

The second VIS_CMAKE_ON overwrites the earlier one.  Should the
values be concatenated or can the first VIS_CMAKE_ON be removed?

The attached patch concatenates them and also switches things to
using the opt_CMAKE_BOOL options helper which is a little easier
to read.

-- 
You are receiving this mail because:
You are the assignee for the bug.