[Bug 235563] New port: emulators/teoemulator: Thomson TO8 Emulator

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235563

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch, needs-qa
             Status|New                         |Open

--- Comment #2 from Tobias Kortkamp <tobik at freebsd.org> ---
Any reason to name the package teoemulator instead of just teo?  AFAICT the
teo package name is still free.

XUSES=          gmake pkgconfig

This is missing USES=gnome.  Please define DEVELOPER=yes in your
/etc/make.conf when testing ports to enable more QA warnings.

XINSTALLS_ICONS=        no

The framework checks if INSTALLS_ICONS is defined or not.  The value doesn't
matter much.  So if the intent is to not have a gtk-update-icon-cache
dependency, then this should be dropped, otherwise it should be "yes" for
consistency with other ports.  It looks like you can safely remove this.

XPLIST_DIRS=    ${DATADIR_REL}/rom      \
X       ${DATADIR_REL}/icons
XROM_FILES=     basic1 basic512 expl extramon monitor1 monitor2
XICON_FILES=    leave run step stepover
XPLIST_FILES=   bin/teo \
X       ${ROM_FILES:%=${DATADIR_REL}/rom/%.rom} \
X       ${ICON_FILES:%=${DATADIR_REL}/icons/%.ico}

This is too complicated. It would be nicer if you could generate a
pkg-plist with `make makeplist` instead.

X       @echo "MAKEFILE_INC = makefile.lnx" > ${WRKSRC}/Makefile
X       @echo "include makefile.all" >> ${WRKSRC}/Makefile

Use ${ECHO_CMD} instead of echo.

XDEBUG_CFLAGS_OFF=      -DNDEBUG

This currently does nothing (there is no DEBUG option defined in the port).

-- 
You are receiving this mail because:
You are the assignee for the bug.