[Bug 240048] [NEW PORT] net/sems: SIP media server

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Aug 23 02:18:23 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240048

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nwhitehorn at FreeBSD.org
                URL|                            |https://github.com/sems-ser
                   |                            |ver/sems/
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
             Status|New                         |Open
              Flags|                            |maintainer-feedback?(nwhite
                   |                            |horn at FreeBSD.org)
           Assignee|ports-bugs at FreeBSD.org      |nwhitehorn at FreeBSD.org

--- Comment #1 from Kubilay Kocak <koobs at FreeBSD.org> ---
@Nathan You just need ports committer to review/accept the changes to commit
this change yourself. Happy to help with that if you can that QA (at least
portlint -AC, poudriere) passes. There's at least a couple of minor ports
compliance issues at first glance:

- WRKSRC override shouldn't be required with USE_GITHUB/GH_* vars setup
correctly

+USE_GITHUB=    yes
+GH_ACCOUNT=    sems-server
+GH_TAGNAME=    7400051

should be after USES

- USES/USE should all be grouped/sorted [1] 

- Q: DOCSDIR entries contain '1.7.0', this looks like 'real' (possibly
pre-release) version of the software (vs g20190822). Given previous release is
1.6.0 [2], DISTVERSION=1.7.0.a<datestamp> or DISTVERSION=1.7.0.g<datestamp> is
probably better, as this will allow the future 1.7.0 release version to be >
than that version string:

# pkg version -t 1.7.0 1.7.0.g20190822
>
# pkg version -t 1.7.0 1.7.0.a20190822
>


If you'd like to create a phabricator review, add 'contributor reviewers
(ports)' (and myself if you like) to the Reviewers list, that should get you
the review you need

^Triage: Reporter is (src) committer, assign accordingly

[1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html
[2] https://github.com/sems-server/sems/releases

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list