[Bug 236944] security/strongswan: startup script improvements

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Apr 22 15:02:21 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236944

Sam Chen <sc.gear at one.caeon.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sc.gear at one.caeon.com

--- Comment #5 from Sam Chen <sc.gear at one.caeon.com> ---
Hi Jose, thanks for making the code better.  Small observations and
suggestions, if you will:
1) check_charon() - Consider rc.subr err() to throw messages.  Why exit code 7
?  Since "swanctl --stats" sets errno 61 on VICI socket failure.
2) wait_charon() - Consider hard-code the wait interval (e.g. "sleep 5").  Else
while loop runs command "sleep 1" five times when $charon_pidfile exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list