[Bug 218515] [NEW PORT] devel/naken_asm: Assembler/disassembler multiple CPUs

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218515

--- Comment #3 from Tobias Kortkamp <tobik at freebsd.org> ---
(In reply to mike from comment #2)

XPORTVERSION=   2017.04.09
XDISTNAME=      naken_asm-2017-04-09

Remove both and set

DISTVERSION=    2017-04-09

instead.

Probably could use an update to the newest version too.

XPKGNAMEPREFIX= naken_asm-

This will result in a package name of naken_asm-naken_asm which
makes little sense.

X#RUN_DEPENDS=  libreadline.so:devel/readline

Useless (and also wrong) comment.

XGNU_CONFIGURE= yes

Port does not use an autotools generated configure script, so it
should be HAS_CONFIGURE instead.

configure seems to use bash so it looks like there is a missing
BUILD_DEPENDS for it here.

X       @mkdir -p ${STAGEDIR}${PREFIX}

mkdir -p should be ${MKDIR}, but it's also unnecessary here.  A
stage directory and prefix skeleton is already created from
/usr/ports/Templates/BSD.local.dist by the framework.

X       @cp ${WRKSRC}/naken_asm ${STAGEDIR}${PREFIX}/bin/

Never use cp in do-install.  Use one of the INSTALL_* macros, here
${INSTALL_PROGRAM}.  It'll make sure that the binaries have the right
permissions and that they are stripped.

XWWW: http://www.mikekohn.net/micro/naken_asm.php
X
X

Superfluous new lines at the end of pkg-descr.

X/usr/local/bin/naken_asm
X/usr/local/bin/naken_util

A two line pkg-plist should just be folded directly into PLIST_FILES
in the Makefile.  Also drop the /usr/local/ prefix here.  PREFIX can
be overridden by users and it's implied if the path is relative.

Other issues:

- Missing LICENSE and LICENSE_FILE
- The port does not respect CFLAGS and LDFLAGS as set by the framework/users
  https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html

-- 
You are receiving this mail because:
You are the assignee for the bug.