[Bug 231189] security/py-gssapi: Strip libraries; add ssl
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Sun Sep 16 13:38:33 UTC 2018
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231189
--- Comment #2 from John W. O'Brien <john at saltant.com> ---
Created attachment 197144
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=197144&action=edit
security/py-gssapi: Strip shared objects, use ssl when needed
Nathan, I've revised your patch as follows.
* Before patching, poudriere testport only emits the USES=ssl warning if
GSSAPI_BASE is selected. With your patch, it no longer warns on GSSAPI_BASE,
but does emit "Warning: you may not need USES=ssl" on both other GSSAPI
options. Therefore I moved "ssl" from the general USES to GSSAPI_BASE_USES.
Could you please confirm that this also works for you?
* I would prefer to avoid the sub-shell + cd pattern in this case. There is
no benefit to setting the CWD on behalf of the subsequent work---as there would
be for running a test suite, for instance---so stripping in three steps instead
of one just adds complexity, and is more likely to increase the scope of future
diffs. While here, I parameterize the package directory.
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-ports-bugs
mailing list