[Bug 223594] New port: net/parpd Proxy-ARP daemon

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223594

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
           Assignee|ports-bugs at FreeBSD.org      |tobik at freebsd.org

--- Comment #6 from Tobias Kortkamp <tobik at freebsd.org> ---
(In reply to Nathan from comment #5)
> What I’d change would be ${MAN8PREFIX}/man/man8 to ${MANDIRS}/man8

No, it's correct as is.  MANDIRS (as the name implies) can be multiple 
directories.

+eval ": \${${name}_enable:='NO'}"
+eval ": \${${name}_flags:=%%PREFIX%%/etc/${name}.conf}"
+eval "config_file=\$${name}_flags"
+
+[ -s "$config_file" ] ||  err 1 "Missing configuration file '$config_file'"
+
+if get_pidfile_from_conf pidfile "$config_file"; then
+  pidfile="$_pidfile_from_conf"
+else
+  err 1 "$config_file does not specify an pidfile"
+fi

This looks dubious to me.  Can you put this in a start_precmd instead?

Otherwise this LGTM.

-- 
You are receiving this mail because:
You are the assignee for the bug.