[Bug 231770] databases/sqlite3: Add ICU flavor

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231770

--- Comment #2 from Matt <fsbruva at yahoo.com> ---
See: https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html.
Look especially example 7.3, where flavors directly control build variables,
rather than port OPTIONS.

I looked at your patch, but cannot test until tonight. I believe using the
OPTIONS_DEFAULT will permit the proper package creation install via 'pkg'.
However, I believe this method can be broken by the user if built from the
ports tree. This is because regardless of the OPTIONS_DEFAULT value(s), the
user can de-select the ICU option during 'make config'. In this case, the
resulting package will have the -icu suffix once installed, but SQLite won't
actually be linked against ICU. This will lead to unacceptable ambiguity. 

This is why my patch completely overrides the OPTIONS list, and makes the ICU
dependency non-optional for the -icu flavor. I will test tonight, and revise my
patch to include your proposed "mini" flavor.

-- 
You are receiving this mail because:
You are the assignee for the bug.