[Bug 233662] graphics/djvulibre: Take MAINTAINER'ship

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233662

Lorenzo Salvadore <phascolarctos at protonmail.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #199683|0                           |1
        is obsolete|                            |
 Attachment #199684|                            |maintainer-approval+
              Flags|                            |

--- Comment #2 from Lorenzo Salvadore <phascolarctos at protonmail.ch> ---
Created attachment 199684
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=199684&action=edit
djvulibre adoption patch, correction 1

About the line I declared deprecated:
https://www.freebsd.org/doc/en/books/porters-handbook/quick-porting.html#porting-makefile
At this page, in the grey box, it is written "This additional information has
been declared obsolete, and is being phased out." See also this wiki page where
I put together such controversial cases (it is a discussion page, I am willing
to modify it of course if I am wrong about anything):
https://wiki.freebsd.org/LorenzoSalvadore/Contradictions
Moreover, I do not think that keeping old ports signatures and discouraging new
signatures at the same time makes sense: it is unfair to new users. For
example, I tried myself to sign a new port I created and saw the committer
removed the signature line: I think he did right for the reasons I wrote in the
wiki page, but I also think all signature lines should be allowed or disallowed
following a unique rule.
I would like to point out that I have no intention to be rude toward anyone, in
particular I do not want to be rude toward the original creator of the port.

I fixed the rest by removing the CONFIGURE_WITH line as you suggestested. I
tested with poudriere successfully (11.2-RELEASE-p5, i386/amd64).

-- 
You are receiving this mail because:
You are the assignee for the bug.