[Bug 212097] [NEW PORT] www/apt-cacher-ng: Caching proxy for software distribution sites port (includes FreeBSD customization)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212097

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ports-bugs at FreeBSD.org      |tobik at freebsd.org

--- Comment #7 from Tobias Kortkamp <tobik at freebsd.org> ---
ould you order the variables according to [1]? 

XThis is a port of apt-cacher-ng, a caching http/s proxy specialized in

Never start pkg-descr with "This is a port".  How about starting
with "apt-cacher-ng is a caching ..." instead?  There are also some
typos in pkg-descr.

XMore details are on the original projects web page.

I think this sentence is superfluous and could be dropped.  It's
pretty much why pkg-descr always ends with WWW.

XOPTIONS_DEFAULT=       SSL DOCS

DOCS is always enabled by default, so it doesn't need to be here.

X#SSL_BUILD_DEPENDS=    pkg-config:devel/pkgconf
X#SSL_BUILD_DEPENDS=    pkg-config:devel/pkgconf openssl:security/openssl
X#SSL_LIB_DEPENDS=      libcrypto.so:security/openssl

Please remove all the commented out variables.  Especially these
very wrong bits.

XSSL_DESC=      Include SSL support to allow proxying https sites.

Remove the dot at the end.

XFUSE_DESC=     Include FUSE support.

FUSE already has a better common description.  What does the
option do in the context of the port (maybe mention acngfs)?

XDISTNAME=      ${PORTNAME}_${PORTVERSION}.orig

You can eliminate setting WRKSRC below if you use

DISTFILES=      ${PORTNAME}_${PORTVERSION}.orig${EXTRACT_SUFX}

instead here.

Xpost-stage:

Use post-install

X       ${INSTALL_MAN} ${WRKSRC}/COPYING ${STAGEDIR}${DOCSDIR}
X       ${INSTALL_MAN} ${WRKSRC}/ChangeLog ${STAGEDIR}${DOCSDIR}
X       ${INSTALL_MAN} ${WRKSRC}/TODO ${STAGEDIR}${DOCSDIR}

Use INSTALL_DATA to install documentation.

COPYING is already installed via LICENSE_FILE.  No need to install
it twice.  Does the ChangeLog and TODO really contain useful
information for users?

X       ${INSTALL_MAN} ${WRKDIR}/Readme.FreeBSD ${STAGEDIR}${DOCSDIR}

I think this should be a pkg-message instead, so that users see it
after installation.

[1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

-- 
You are receiving this mail because:
You are the assignee for the bug.