[Bug 233360] [new port] security/otp OTP tool

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233360

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch, needs-qa

--- Comment #1 from Tobias Kortkamp <tobik at freebsd.org> ---
XRUN_DEPENDS=   ${PREFIX}/bin/gpg:security/gnupg \
X               ${PREFIX}/bin/oathtool:security/oath-toolkit \
X               ${SITE_PERL}/JSON.pm:converters/p5-JSON

PREFIX is where a port installs into, LOCALBASE is where a ports'
dependencies come from.  So ${LOCALBASE} should be used here.
However we generally just drop ${LOCALBASE}/bin from dependency
specs like this.

XUSE_GNOME=     glib20 gtk30
XPLIST_SUB=     X11=""
XINSTALLS_ICONS=        yes

This is missing USES+=gnome and probably more since otp_gui appears
to be a Perl application.  Is a p5-Gtk3 dependency or similar not
missing too?

Xdo-extract:
X       ${SVN} co -r ${SVN_REVISION} ${MASTER_SITES} ${WRKSRC}

I'm sorry but this is not acceptable and won't work in Poudriere
either.  Files need to be checksummed via distinfo and no network
connection is allowed in the extract phase.  Please create a tarball
and use that instead for the port.

Xbin/otp

This port conflicts with security/heimdal which installs a 'bin/otp'
too.

XFLAVORS=       x11 nox11
XFLAVOR?=       ${FLAVORS:[1]}

Flavors need portmgr approval, so best put it up on
https://reviews.freebsd.org yourself after addressing the above
points.

-- 
You are receiving this mail because:
You are the assignee for the bug.