[Bug 233352] print/qpdfview: improves USES flags and options

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233352

            Bug ID: 233352
           Summary: print/qpdfview: improves USES flags and options
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: phascolarctos at protonmail.ch
                CC: mbeis at xs4all.nl
             Flags: maintainer-feedback?(mbeis at xs4all.nl)
                CC: mbeis at xs4all.nl

Created attachment 199376
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=199376&action=edit
qpdfview patch

My patch fixes some problems issued by portlint and poudriere and improves
options management.

- Adds USE_GL= gl and USES+= gl, as required by poudriere.
- Adds a line before QMAKE_SOURCE_PATH  to separate it from the USE block, as
required by portlint.
- Adds QT4_USE+= qt+=corelib and QT5_USE+= qt+=core,dbus,gui,widgets, as
required by poudriere. (I am unsure the syntax I used in this changelog would
be correct, but the one I used in the Makefile surely is: I just added the
needed words where they were needed.)

- Moves the DJVU and PS option from OPTIONS_MULTI_BACKEND to OPTIONS_DEFINE,
because they should be both optional, but the BACKEND construction requires
that at least one of them be selected. (I think BACKEND was introduced to put
the nice title "Additional documents support" over the two options, but because
of the unwanted side effect it should be removed.)
- Makes QT5 default instead of QT4, because it is more recent. (I use qpdfview
with QT5 almost everyday since months: it works perfectly.)

Everything has been tested on poudriere 11.2-RELEASE amd64/i386.

-- 
You are receiving this mail because:
You are the assignee for the bug.