[Bug 232936] lang/scm fails to build with GCC 8

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232936

--- Comment #7 from Gerald Pfeifer <gerald at FreeBSD.org> ---
(In reply to Tobias Kortkamp from comment #5)
> I guess we can land this with maintainer timeout [Wednesday]

Yes, please.  This is the last PR blocking the update to GCC 8 as the
default.

> Should the CFLAGS hack be made conditional on the GCC version?
> Not exactly sure how to add such a check though given that the port
> uses USE_GCC=any vs USE_GCC=yes.

USE_GCC=any really only should make a difference on non-tier 1 
architectures that still have the age old GCC 4.2 as a system
compiler.  Everywhere else it is the same as USE_GCC=yes.

Hence I would not start hacking around re CFLAGS, and in fact
switch over to USE_GCC=yes: Doesn't make a difference for nearly
everyone and actually gets those lower tier architectures more on
par using what those that are regularly tested/used, increasing
the chance it'll actually build and work there, too.

Thanks for your help with this, Tobias!

-- 
You are receiving this mail because:
You are the assignee for the bug.