[Bug 228596] [NEW PORT] finance/rippled: Reference server implementation of the Ripple protocol

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228596

--- Comment #1 from Tobias Kortkamp <tobik at freebsd.org> ---
(In reply to waitman from comment #0)
> should have at least 8GB RAM to build (according to rippled docs)
So I guess I'm out in ever landing this.  But here is a short review anyway:

XMASTER_SITES=  https://github.com/ripple/rippled/archive/
XDISTNAME=      ${PORTVERSION}
...
XWRKSRC=                ${WRKDIR}/${PORTNAME}-${PORTVERSION}

Please use USE_GITHUB and related variables here instead of GitHub's
archive feature directly.

XNO_ARCH=       yes

Huh?  If the port builds binaries then this is probably wrong.

X               ${INSTALL} ${BUILD_WRKSRC}/rippled ${STAGEDIR}${PREFIX}/sbin/

Use INSTALL_PROGRAM.  Also please fix the indentation here.

X       ${INSTALL_DATA} ${WRKSRC}/cfg/rippled-example.cfg ${STAGEDIR}${DOCSDIR}
X       ${INSTALL_DATA} ${WRKSRC}/cfg/rippled-example.service
${STAGEDIR}${DOCSDIR}
X       ${INSTALL_DATA} ${WRKSRC}/cfg/rippled.init ${STAGEDIR}${DOCSDIR}
X       ${INSTALL_DATA} ${WRKSRC}/cfg/validators-example.txt
${STAGEDIR}${DOCSDIR}

The *-example* files should probably be installed into EXAMPLESDIR
(under an EXAMPLES option) instead.

X       @${CAT} ${WRKSRC}/MESSAGE

What's the purpose of this?  Nobody will see this message.  It
will be hidden in the build logs on the package builders.  If this
is a message for after the package has been installed, I suppose
you could add

PKGMESSAGE=     ${WRKSRC}/MESSAGE

to the port instead (then there is no point to also install it into
DOCSDIR too).

-- 
You are receiving this mail because:
You are the assignee for the bug.