[Bug 212097] [NEW PORT] www/apt-cacher-ng: Caching proxy for software distribution sites port (includes FreeBSD customization)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212097

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch, needs-qa
                 CC|                            |tobik at freebsd.org

--- Comment #3 from Tobias Kortkamp <tobik at freebsd.org> ---
XLICENSE_FILE=  ${WRKSRC}/COPYING

Setting LICENSE_FILE without also setting LICENSE is useless.

XDEFAULT_VERSIONS+=     ssl=openssl

This is a red flag.  A default version effects the entire ports
collection.  It cannot be set in an individual port.

XSSL_BUILD_DEPENDS=     pkg-config:${PORTSDIR}/devel/pkgconf
openssl:${PORTSDIR}/security/openssly

If the port needs openssl then add USES=ssl (or SSL_USES=ssl) and
nothing else.  Since the port already always has USES=ssl maybe the
SSL option isn't really needed and SSL support could always be on.

- All of the ${PORTSDIR} things are old school and should be removed.

XFUSE_CMAKE_ON= -DUSE_FUSE:BOOL=ON
XFUSE_CMAKE_OFF=        -DUSE_FUSE:BOOL=OFF

Replace with (and the other *_CMAKE_{ON,OFF}):

FUSE_CMAKE_BOOL=        USE_FUSE

Can you confirm that this passes portlint and a Poudriere test
build?  In particular a test build on 12.0-BETA4 would be good to
make sure it still builds against OpenSSL 1.1.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.