[Bug 227109] Mk/Scripts, cleanup using devel/hs-ShellCheck

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Jun 8 09:27:27 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227109

--- Comment #20 from commit-hook at freebsd.org ---
A commit references this bug:

Author: mat
Date: Fri Jun  8 09:26:21 UTC 2018
New revision: 471988
URL: https://svnweb.freebsd.org/changeset/ports/471988

Log:
  SC2046: Quote this to prevent word splitting.

  When command expansions are unquoted, word splitting and globbing will
  occur. This often manifests itself by breaking when filenames contain
  spaces.

  Trying to fix it by adding quotes or escapes to the data will not work.
  Instead, quote the command substitution itself.

  If the command substitution outputs multiple pieces of data, use a loop
  instead.

  Add an exception when using set -- where splitting is intended.

  PR:             227109
  Submitted by:   mat
  Exp-run by:   antoine
  Sponsored by:   Absolight

Changes:
  head/Mk/Scripts/check_leftovers.sh
  head/Mk/Scripts/depends-list.sh
  head/Mk/Scripts/find-lib.sh
  head/Mk/Scripts/functions.sh
  head/Mk/Scripts/smart_makepatch.sh

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ports-bugs mailing list