[Bug 227109] Mk/Scripts, cleanup using devel/hs-ShellCheck

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227109

Mathieu Arnold <mat at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193646|0                           |1
        is obsolete|                            |

--- Comment #18 from Mathieu Arnold <mat at FreeBSD.org> ---
Created attachment 193895
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193895&action=edit
base commit: r471274

First non "noop" commit:

    SC2046: Quote this to prevent word splitting.

    When command expansions are unquoted, word splitting and globbing will
    occur. This often manifests itself by breaking when filenames contain
    spaces.

    Trying to fix it by adding quotes or escapes to the data will not work.
    Instead, quote the command substitution itself.

    If the command substitution outputs multiple pieces of data, use a loop
    instead.

    Add an exception when using set -- where splitting is intended.

-- 
You are receiving this mail because:
You are on the CC list for the bug.