[Bug 225320] New port: lang/RETRO: clean, elegant, and pragmatic dialect of Forth

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225320

--- Comment #2 from Mateusz Piotrowski <mpp302 at gmail.com> ---
(In reply to Matthew Seaman from comment #1)

>  * With certain narrow exceptions, port and pkg names 
>    are usually all lower-case. 
Sure, I'll update the patch soon. 

I'd like to add that the NetBSD port is called "lang/forth-retro", and LiteBSD
ports are called retro12 and retro11..

>  * It also seems like the '12' part of the version number is intrinsic to 
>     the software name, and the version number is just the encoded date
>    
>    - Could you rename the to lang/retro12 and the PORTNAME to retro12 
>      please?
>    - Use DISTVERSION=2018.1 rather than inventing a PORTVERSION
>    - Given that, you shouldn't need to set DISTNAME as the default will 
>      do the right thing.
>    - Similarly you shouldn't need to override the setting for WRKSRC
I tried to follow the format mentioned in the section 5.2.5.: "0.0.yyyy.mm.dd",
because (as you've probably seen here [1]) the versioning of RETRO fits
perfectly this format.

I'll apply the suggestions you mentioned in the next version of the patch.

>  * You've listed the maintainer as 0mp at FreeBSD.org -- I can't find 
>    that as a known user.  You should put your own e-mail address 
>    in as the maintainer.
I am a former Google Summer of Code student and I use 0mp@ daily, although I do
not have any commit bit. I am already mentioned like this as a maintainer of
accessibility/sct. I cannot use this email address as my primary address on
Buzilla, however, because FreeBSD.org emails are automatically considered to be
in the committer group or something.

>  * You don't need to explain all about the location of 
>    documentation and examples and other data in pkg-descr -- this is 
>    standard functionality and applies automatically for every port.
>    
>  * Similarly for pkg.message -- you're describing boiler-plate 
>    functionality.  I'd remove pkg-message entirely: remember, 
>    less is more here and pkg-message should be reserved only for 
>    those occasions where it is really needed.
Sure, I'll remember about it in the next version.

Thank you for your review!

I'll submit an updated patch soon.

[1]: https://forthworks.com/retro/r

-- 
You are receiving this mail because:
You are the assignee for the bug.