[Bug 224816] emulators/open-vm-tools: Fix build with clang 6.0.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224816

            Bug ID: 224816
           Summary: emulators/open-vm-tools: Fix build with clang 6.0.0
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: jpaetzel at FreeBSD.org
          Reporter: dim at FreeBSD.org
          Assignee: jpaetzel at FreeBSD.org
             Flags: maintainer-feedback?(jpaetzel at FreeBSD.org)

Created attachment 189312
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=189312&action=edit
Fix tautological (endless) loop in vixTools.c

While testing the new clang600-import branch (see bug 224669), I noticed that
open-vm-tools fails to compile, due to a new warning in clang 6.0.0:

--- libvix_la-vixTools.lo ---
vixTools.c:7333:22: error: result of comparison 'int' <= 4294967295 is always
true [-Werror,-Wtautological-constant-compare]
   for (var = 0; var <= 0xFFFFFFFF; var++) {
                 ~~~ ^  ~~~~~~~~~~
1 error generated.

Here is a patch to fix that particular error, and this also avoids an endless
loop in practice.

-- 
You are receiving this mail because:
You are the assignee for the bug.