[Bug 224808] New x11-fonts/nerd-fonts-complete 1.2.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224808

Joseph Mingrone <jrm at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jrm at freebsd.org

--- Comment #1 from Joseph Mingrone <jrm at freebsd.org> ---
- You need to start with the line
# $FreeBSD$

- Why not PORTNAME=nerd-fonts, then you can remove GH_PROJECT= nerd-fonts.

- COMMENT is too long and should not start with 'A".  Maybe:
COMMENT=Collection of over 20 patched fonts

- The block order should conform to 'Order of Variables in Port Makefiles' in
the Porter's Handbook.
USES=           fonts
USE_GITHUB=     yes
GH_ACCOUNT=     ryanoasis

NO_ARCH=        yes
NO_BUILD=       yes

There are pkg-plist issues because of empty directories.  Maybe add this to the
do-install target.

        @${RMDIR} ${STAGEDIR}${FONTSDIR}/ProFont/ProFontWinTweaked/complete \
                ${STAGEDIR}${FONTSDIR}/ProFont/ProFontWinTweaked \
                ${STAGEDIR}${FONTSDIR}/ProFont/profont-x11 \
                ${STAGEDIR}${FONTSDIR}/Terminus/BDF \
                ${STAGEDIR}${FONTSDIR}/Terminus/PCF \
                ${STAGEDIR}${FONTSDIR}/Terminus/PSF \

ports-mgmt/portlint is helpful for detecting issues (but is not perfect).

-- 
You are receiving this mail because:
You are the assignee for the bug.