[Bug 225687] dns/bind99, dns/bind910, dns/bind911, dns/bind912: rc script defaults to wrong pid location

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225687

            Bug ID: 225687
           Summary: dns/bind99, dns/bind910, dns/bind911, dns/bind912: rc
                    script defaults to wrong pid location
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: easy, patch, patch-ready
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: mat at FreeBSD.org
          Reporter: john at saltant.com
 Attachment #190343 maintainer-approval?
             Flags:
             Flags: maintainer-feedback?(mat at FreeBSD.org)
          Assignee: mat at FreeBSD.org

Created attachment 190343
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=190343&action=edit
dns/bind9x: Fix pid file location in rc script

Synopsis
========

All versions of the BIND 9 port supply an rc script (files/named.in) that
determine the location of the pid file by searching the config file and falling
back to a hard-coded default. The rc default and the location specified in the
sample config file are the same, which is unnecessary, but the rc default is
not the same as the default location compiled into the named binary, which is
necessary.


Ports affected
==============

    dns/bind99
    dns/bind910
    dns/bind911
    dns/bind912


Expected behavior
=================

1. Specify the pid location in the config file

The named binary writes a pid file to the specified location.

The named rc script finds the pid location with get_pidfile_from_conf.


2. Don't specify the pid location in the config file

The named binary writes a pid file to /var/run/named/named.pid.

The named rc script finds no pid location with get_pidfile_from_conf and
defaults to /var/run/named/named.pid


Observed behavior
=================

1. Specify the pid location in the config file [PASS]

The named binary writes a pid file to the specified location.

The named rc script finds the pid location with get_pidfile_from_conf.


2. Don't specify the pid location in the config file [FAIL]

The named binary writes a pid file to /var/run/named/named.pid.

The named rc script finds no pid location with get_pidfile_from_conf and
defaults to /var/run/named/pid, which does not exist.



Fix
===

The attached patch updates the RC scripts so the default PID location matches
the binary default.

-- 
You are receiving this mail because:
You are the assignee for the bug.