[Bug 224821] databases/mongodb36: fails to build with boost 1.66

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224821

--- Comment #14 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 189929
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=189929
3.6.2, boost 1.66 fix

(In reply to Vlad Galu from comment #13)
> Can this be merged then?

databases/mongodb36 currently doesn't exist.

>  LIB_DEPENDS=	libpcre.so:devel/pcre \
> -		libsnappy.so:archivers/snappy \
> -		libboost_system.so:devel/boost-libs
> +		libboost_system.so:devel/boost-libs \
> +		libsnappy.so:archivers/snappy

Please, sort by port origin/directory or just drop patch churn.

> ---- SConstruct.orig	2017-12-01 17:04:06 UTC
> +--- SConstruct.orig	2018-01-04 23:28:55 UTC
[...]
> ---- rpm/mongod.conf.orig	2017-12-01 17:04:06 UTC
> +--- rpm/mongod.conf.orig	2018-01-04 23:28:55 UTC

Unless context lines or offsets have changed this only introduces patch churn.

> +-        oqMetadata = boost::make_optional<rpc::OplogQueryMetadata>(metadataResult.getValue());
> ++        oqMetadata = boost::optional<rpc::OplogQueryMetadata>(metadataResult.getValue());

Why is this different from https://github.com/mongodb/mongo/commit/3c34eda8d8a3
?

-- 
You are receiving this mail because:
You are the assignee for the bug.