[Bug 234518] security/maia: Update to 1.0.4-g20181202, Many bug, port, and PHP fixes.

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234518

            Bug ID: 234518
           Summary: security/maia: Update to 1.0.4-g20181202, Many bug,
                    port, and PHP fixes.
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
               URL: https://github.com/technion/maia_mailguard
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: ek at purplehat.org
 Attachment #200643 maintainer-approval+
             Flags:

Created attachment 200643
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=200643&action=edit
security/maia port patch.

This port has been updated to pull directly from Github as opposed to me having
to host a certain version separately for each commit (I may need assistance
with the proper versioning via PORTEPOCH, though). This has also been
configured to work with proper PHP flavors and the code has been updated to
work with PHP7 as well as Smarty3.

I made some changes to satisfy portlint that I am unsure are correct. Any
advice on this would be great!

1. I was getting warnings regards "USE_GITHUB" being located above the first
"USES_" line so I moved it down. Is this necessary or should it be moved back
up top to the GH_* area for sanity/readability/cleanliness/etc..?

2. The version, now that it is using the handbook's suggestion for Github, is
now appearing older than the previous version. It's suggested to re-version
(which I probably shouldn't do?) or to use PORTEPOCK which I'm not sure how to
properly do. What are the suggestions here?

Portlint output:
WARN: Makefile: possible use of absolute pathname "/var/maiad".                
                                                                               
                                                                               
                                                  │··························
WARN: Makefile: possible use of absolute pathname "/var/maiad/virusmail...".   
                                                                               
                                                                               
                                                  │··························
FATAL: Makefile: maia-1.0.4.g20181202 < maia-1.0.4_3. Choose another
PORTVERSION or bump PORTEPOCH.                                                 
                                                                               
                                                            
│··························
WARN: Makefile: Consider defining LICENSE.                                     
                                                                               
                                                                               
                                                  │··························
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.                           
                                                                               
                                                                               
                                                  │··························
WARN: Makefile: "USES" has to appear earlier.                                  
                                                                               
                                                                               
                                                  │··························
1 fatal error and 5 warnings found. 

Poudriere build log:
http://clarkson.purplehat.org/data/freebsd_11-2x64-HEAD/2018-12-30_21h57m33s/logs/maia-1.0.4.g20181202.log

-- 
You are receiving this mail because:
You are the assignee for the bug.