[Bug 234508] sysutils/grub2: Update to recent snapshot, fix build with GCC 8

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Dec 30 20:14:07 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234508

--- Comment #3 from Tobias Kortkamp <tobik at freebsd.org> ---
(In reply to bergerkos from comment #2
> in this snapshot grub-mkconfig does not make problems prefixing "t"
> as reported in r488585.

It's good that they have fixed most of the non-portable sed -e 's/^/\t/'.
I still see some in at least util/grub.d/30_os-prober.in, so I do not
think that this is fixed completely.  Probably could be easily fixed
with a single patch instead of falling back to gsed now though.

> And as for r484145, I ran portlint and did what it suggested, so
> no it finds no mistakes in my Makefile.

r484145 also removed CONFLICTS, for example.

> Because "USES=autoreconf" doesn't do all that the autogen.sh does.
> That scripts does some other things as well.

Ok, it seems to do a lot.  Is there a need to run autoreconf twice?
Both autogen.sh and the framework do it.  Would USES=autoreconf:build
suffice?

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list