[Bug 234408] games/oolite: Update to 1.88

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234408

lightside <lightside at gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #200519|0                           |1
        is obsolete|                            |

--- Comment #2 from lightside <lightside at gmx.com> ---
Created attachment 200520
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=200520&action=edit
Proposed patch (since 480741 revision)

According to GCC compiler documentation, the alternative name for "-O" is "-O1"
for compiler option:
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html#Optimize-Options

Probably, possible to use "-O1" instead of "-O2", if needed. I just used some
default value in ports for amd64 architecture, which returned by `make -C
/usr/ports -V CFLAGS` command.

The "-O" and "-O2" compiler options are used in /usr/src/share/mk/sys.mk file,
based on different conditions, for example:
https://github.com/freebsd/freebsd/blob/5c861640127b95aa6b29327a48da153695e84c10/share/mk/sys.mk#L164-L177

Also possible, that message in BROKEN_aarch64 variable is outdated and there is
no need for related changes for deps/mozilla/js/src/configure file, after
OBJC_CLANG_VERSION=60 in ports r480741.

As I understood, the "-O" compiler flag is used to build
deps/mozilla/js/src/shell/js.cpp file:
https://github.com/OoliteProject/spidermonkey-ff4/blob/ca2fb5423fab4d72a3dc5fec911ce20bda01f223/js/src/shell/js.cpp

So, I decided to remove related changes from the patch. I guess, someone just
need to check support for "-O" compiler option for aarch64 architecture,
otherwise possible to propose patch to change this value for
deps/mozilla/js/src/configure file.

-- 
You are receiving this mail because:
You are the assignee for the bug.