[Bug 234260] audio/hydrogen: Update to latest commit and switch to Qt 5

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Dec 22 03:46:36 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234260

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[maintainer update] for     |audio/hydrogen: Update to
                   |audio/hydrogen              |latest commit and switch to
                   |                            |Qt 5
             Status|New                         |Open
           Keywords|                            |needs-patch, needs-qa

--- Comment #1 from Tobias Kortkamp <tobik at freebsd.org> ---
Please keep compiler:c++11-lang!  It partially reverts ports r459300
for no reason and will probably break the build on powerpc64 again.

+/usr/share/pixmaps/h2-icon.svg
+ at dir /usr/share/pixmaps

Something is wrong...

+DISTVERSION=   1.0.0.b1
+GH_TAGNAME=    538eaeb9f4e9 # master at 8/10

Please use git describe --tags to derive a proper version here:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5

-do-test-TEST-on:
+do-test:

Why this change?  Is src/tests/tests also available when the port
is compiled with TEST=off?

+USE_QT=        qmake buildtools core gui linguisttools network widgets xml
xmlpatterns

Are qt5-buildtools, qt5-linguisttools, qt5-qmake really run
dependencies of Hydrogen?  Maybe something like this would be better:

USE_QT= core gui network widgets xml xmlpatterns buildtools_build
linguisttools_build qmake_build

Please confirm that this passes a Poudriere test build.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list