[Bug 233726] graphics/qgis: Update to 3.4.2

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233726

Tobias C. Berner <tcberner at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ports-bugs at FreeBSD.org      |tcberner at freebsd.org
                 CC|                            |tcberner at freebsd.org
             Status|Open                        |In Progress

--- Comment #2 from Tobias C. Berner <tcberner at freebsd.org> ---
Moin moin

Thanks for the patch :) 


I noticed some issues when looking at it:

-DQSCI_SIP_DIR:PATH=${LOCALBASE}/share/PyQt5/3.6/sip/Qsci 
this should probably be 
-DQSCI_SIP_DIR:PATH=${PYQT_APIDIR}

and this
-DSIP_DEFAULT_SIP_DIR:FILEPATH=${LOCALBASE}/share/PyQt5/3.6/sip
should be
-DQSCI_SIP_DIR:PATH=${PYQT_SIPDIR}



Instead of writing
CMAKE_ARGS= -DWITH_3D:BOOL=TRUE 
you can do
CMAKE_ON=  WITH_3D
respectively 
CMAKE_OFF=  WITH_QWTPOLAR



Instead of
GRASS_CMAKE_ON=         -DWITH_GRASS7:BOOL=TRUE
GRASS_CMAKE_OFF=        -DWITH_GRASS7:BOOL=FALSE
you could write 
GRASS_CMAKE_BOOL=   WITH_GRASS7


* Your pre-configure looks like something for BINARY_ALIAS, or shebangfix
* Your post-configure targets should again use the ${OYQT_APIDIR}, otherwise it
will only work for python-3.6.


* patch-cmake_PyQtMacros.cmake is wrong :D 




mfg Tobias

-- 
You are receiving this mail because:
You are the assignee for the bug.