[Bug 210505] graphics/opencv: Update to 3.4.1

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210505

--- Comment #76 from Jan Beich <jbeich at FreeBSD.org> ---
(In reply to Steve Wills from comment #75)
> +CMAKE_ON=	ENABLE_CXX11
> +CMAKE_OFF=	BUILD_ZLIB BUILD_TIFF BUILD_JASPER BUILD_JPEG BUILD_PNG BUILD_OPENEXR BUILD_TBB BUILD_IPP_IW BUILD_ITT BUILD_PROTOBUF

To fit on ~80 column terminal maybe wrap long lines

  CMAKE_ON=  ENABLE_CXX11
  CMAKE_OFF= BUILD_ZLIB BUILD_TIFF ... \
             BUILD_ITT BUILD_PROTOBUF

or use += but group e.g.,

  CMAKE_OFF+= BUILD_ZLIB
  CMAKE_OFF+= BUILD_TIFF
  CMAKE_OFF+= BUILD_JASPER
  ...

> +# Optional 3rd party components
> +CMAKE_ARGS+=	-DWITH_1394:BOOL=OFF \
> +		-DWITH_CAROTENE:BOOL=OFF \

Sorry, I meant to convert all (unconditional) CMAKE_ARGS to CMAKE_ON/OFF.

> -V4L_CMAKE_ON=		-DCMAKE_REQUIRED_INCLUDES:STRING="${LOCALBASE}/include"
> +V4L_CMAKE_ON=		CMAKE_REQUIRED_INCLUDES:STRING="${LOCALBASE}/include"

A typo: missing -D. Simply drop the change to the line.

> Are there more to do or is that all that's needed?

That was readability cosmetics. Review is not blocking (no maintainer) and can
be done in parallel to exp-run. Or did you try to build all consumers locally?

-- 
You are receiving this mail because:
You are the assignee for the bug.