[Bug 227500] audio/mous: update to 2.0.1

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227500

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik at freebsd.org

--- Comment #2 from Tobias Kortkamp <tobik at freebsd.org> ---
Thanks for your submission.

While this looks mostly ok to me there here are couple of things that
could be improved.  Can you submit an updated patch?

+MASTER_SITES=  GH

USE_GITHUB=yes already implies the same, so this can be removed.

+PORTVERSION=   2.0.1
+DISTVERSIONPREFIX= v
...
+GH_TAGNAME=    v2.0.1

Remove GH_TAGNAME.  DISTVERSIONPREFIX + PORTVERSION already sets it to
the same value.

+CMAKE_ARGS+=   -DWITH_PLUGIN_ALSA=0 \
+               -DWITH_PLUGIN_LIBAO=0 \
+               -DWITH_PLUGIN_COREAUDIO=0 \
+               -DWITH_PLUGIN_FAAC=0 \
+               -DWITH_PLUGIN_FAAD=0 \
+               -DWITH_PLUGIN_WMA=0

This should use CMAKE_OFF i.e.

CMAKE_OFF=      WITH_PLUGIN_ALSA \
                WITH_PLUGIN_LIBAO \
                WITH_PLUGIN_COREAUDIO \
                WITH_PLUGIN_FAAC \
                wITH_PLUGIN_FAAD \
                WITH_PLUGIN_WMA

+SNDIO_CMAKE_ON=                -DWITH_PLUGIN_SNDIO=1
+SNDIO_CMAKE_OFF=       -DWITH_PLUGIN_SNDIO=0

This can be replaced by the much easier to read

SNDIO_CMAKE_BOOL=       WITH_PLUGIN_SNDIO

This also applies to all the other *_CMAKE_{ON,OFF} pairs.

+USES=          cmake:outsource,noninja compiler:c++14-lang

Why is noninja needed?  Having a small comment in the Makefile to
explain why it's needed is always nice.

+INSTALL_TARGET=        install/strip

This can probably be removed too.  Uses/cmake.mk already sets it.

-- 
You are receiving this mail because:
You are the assignee for the bug.